FEAT: Piccolo Proof of Concept #625
Conversation
DinoAGW
commented
Jun 12, 2020
DinoAGW
commented
- First complete try to use Picolo as a config objectl and
- fixed faulty package-info stuff.
- short demo showing use of Picolo as a config objectl and - fixed faulty package-info stuff.
FEAT: Piccolo Proof of Concept
Codecov Report
@@ Coverage Diff @@
## integration #625 +/- ##
==============================================
Coverage 45.63% 45.63%
Complexity 1046 1046
==============================================
Files 57 57
Lines 9149 9149
Branches 1687 1687
==============================================
Hits 4175 4175
Misses 4424 4424
Partials 550 550 Continue to review full report at Codecov.
|
carlwilson
added
bug
|
@david-russo and @tledoux I've asked you both to take a look at this as I know you'd both expressed opinions. I'm going to write some tests for illegal parameter combos and the like and add param descriptions. It also seems sensible to factor out the description strings as resources. That aside, it all looks good. |
There was a problem hiding this comment.
Assuming all the TBD are addressed, and it supports at least what the current one does, the use of picocli already looks like a vast improvement to me. I don't see any problems with the logic either, it only seems to need some comment clean up and option descriptions.
Passing the old -P or -p options will now probably cause the CLI to exit with an 'unknown option' message of some kind (I haven't actually run the code). Those options have had no effect for a while though, so this is probably as good a time as any to alert people to that.
